fix(llm): surface claude-cli errors reported on stdout#1864
Open
davetothek wants to merge 1 commit into
Open
Conversation
The claude CLI reports usage-limit and auth errors on stdout with an empty stderr, so failures surfaced as a bare "claude -p exited 1:". Fall back to the stdout tail when stderr is empty. Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The
claudeCLI reports usage-limit and auth errors on stdout with anempty stderr while exiting non-zero.
_call_claude_cli/_call_llmonly readproc.stderr, so these failures surfaced as a bareclaude -p exited 1:withno indication of the actual cause — an unrecoverable usage limit looked
identical to any other non-zero exit.
Fall back to the stdout tail when stderr is empty, so the surfaced error carries
the real message. Adds
tests/test_llm_errors.pycovering both paths (preferstderr when present; fall back to stdout otherwise).