fix: persist manifest after _rebuild_code (fixes #538) - #621
Closed
HughScott2002 wants to merge 1 commit into
Closed
fix: persist manifest after _rebuild_code (fixes #538)#621HughScott2002 wants to merge 1 commit into
HughScott2002 wants to merge 1 commit into
Conversation
graphify update, graphify watch, and the installed post-checkout hook all call _rebuild_code() but never call save_manifest(). On the next detect_incremental call the manifest read returns a stale baseline, so every file looks "new" and the rebuild re-fires every time. Add save_manifest(detected['files']) at the end of _rebuild_code, gated by try/except so a manifest write failure does not fail the rebuild. detected was already built at the top of the function, so this is a one-line write at no extra cost. Single edit covers three call sites: graphify update (CLI), the watch loop, and .git/hooks/post-checkout. Does not touch the skill markdown pipeline mentioned in the issue's suggested fix; that path may still need its own Step 9 patch.
safishamsi
added a commit
that referenced
this pull request
May 1, 2026
Collaborator
|
The requested changes have been implemented in 3fdae8f. |
matzls
pushed a commit
to matzls/graphify
that referenced
this pull request
May 10, 2026
…bs#638 Graphify-Labs#589 Graphify-Labs#586 Graphify-Labs#593: kimi thinking, manifest, inline comments, query boost, cache race, markdownify, content hash Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
graphify update,graphify watch, and the installed.git/hooks/post-checkoutall call_rebuild_code()but never callsave_manifest().detect_incremental()reads a stale baseline on the next call, so every file looks new and the rebuild re-fires every time._rebuild_codeusing thedetecteddict already built at the top of the function. Gated bytry/exceptso a manifest write failure cannot fail the rebuild.Closes #538.
Single edit covers three call sites: the CLI
updatecommand, thewatchloop, and the post-checkout hook. The skill markdown pipeline mentioned in the issue's suggested fix is a separate surface and may still need its own Step 9 patch.Test plan
v5:rm graphify-out/manifest.json && graphify update .→ no manifest written, nextdetect_incrementalreports every file as new.rm graphify-out/manifest.json && graphify update .→manifest.jsonwritten (~35KB, 360 entries on a real repo).detect_incrementalimmediately after rebuild → returnsnew_total: 0, deleted: 0.True.