fix: ignore search punctuation in graph queries#994
Conversation
safishamsi
left a comment
There was a problem hiding this comment.
Thanks for the PR! The core fix looks good, but the test file changes are unrelated to the PR's purpose (you've edited test_build.py to modify node_link_data tests that are unrelated to this PR's scope). Could you revert those test changes and keep only the changes relevant to this PR? That will make it easier to review and merge.
2c996b8 to
2b08688
Compare
|
Addressed, thanks. I reverted the unrelated node_link_data fixture compatibility edits and kept the PR scoped to punctuation normalization plus the focused regression tests. I also updated the PR test section to note that the local CLI regression is blocked by the existing NetworkX fixture call after reverting that change. |
2b08688 to
14fca7a
Compare
|
Implemented in v8 (commit 80301a0). Added |
Summary:
Why:
Tests:
Scope: