fix: use cast preimages for cast predicate rewrites#10
Closed
discord9 wants to merge 9 commits into
Closed
Conversation
Signed-off-by: discord9 <discord9@163.com>
Signed-off-by: discord9 <discord9@163.com>
Signed-off-by: discord9 <discord9@163.com>
Signed-off-by: discord9 <discord9@163.com>
Signed-off-by: discord9 <discord9@163.com>
Author
|
Closing this PR because it targeted the wrong base branch (). GreptimeDB currently depends on the branch/rev, so the fix has been reopened against the correct base in #11. |
Author
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Which issue does this PR close?
Rationale for this change
GreptimeDB can produce incorrect timestamp predicate results when a timestamp column is compared through a lower-precision cast, for example matching
2026-06-02 03:50:00.195for a<= '2026-06-02 03:50:00'predicate.The existing cast predicate rewrite can unwrap casts that are not one-to-one, which changes predicate semantics for timestamp precision narrowing and other lossy casts. This ports the upstream Apache DataFusion cast-preimage fix so predicate rewrites are only applied when the preimage is known to preserve semantics.
What changes are included in this PR?
datafusion-expr-common.Are these changes tested?
This is a direct port of the upstream Apache DataFusion fix from apache#22906, whose CI passed upstream.
Local tests were intentionally skipped for this urgent fork PR so GreptimeTeam CI can validate the branch as soon as possible.
Are there any user-facing changes?
Yes. Query results for predicates involving lossy casts become more correct and conservative: unsafe cast unwrapping is avoided, and timestamp precision narrowing is rewritten using ranges that preserve predicate semantics.