Allow dynamic filter pushdown for left join#2
Closed
discord9 wants to merge 1 commit into
Closed
Conversation
Author
|
Closing duplicate; please use #3. |
Author
|
Duplicate of #3. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary\n- allow join dynamic filter pushdown for LEFT JOIN in HashJoinExec\n- keep existing INNER JOIN behavior unchanged\n\n## Rationale\nFor LEFT JOIN, the dynamic filter is built from the preserved left/build side and applied to the right/probe side. Filtering the right side by left-side join keys is semantically safe because unmatched left rows are still preserved and padded with NULLs.\n\n## Validation\n- cargo check -p datafusion-physical-plan --lib\n- GreptimeDB integration smoke: cargo test -p tests-integration remote_dyn_filter_test -- --nocapture\n - verified HashJoinExec: mode=CollectLeft, join_type=Left\n - verified right-side MergeScanExec receives non-empty dyn_filters\n - verified unmatched left key remains in LEFT JOIN output\n