feat: expose dynamic filter completion state#8
Open
discord9 wants to merge 1 commit into
Open
Conversation
Signed-off-by: discord9 <discord9@163.com>
5 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What changed
Expose a non-blocking
DynamicFilterPhysicalExpr::is_complete()getter and add tests for its completion-state semantics.Why
GreptimeDB remote dynamic filter initial snapshots need to capture whether the producer-side dynamic filter is already complete without awaiting
wait_complete().DynamicFilterPhysicalExpralready tracks this state internally andwait_complete()reads it as a fast path, so this exposes that state as a documented snapshot-style API.The getter is intentionally non-blocking and does not synchronize with concurrent updates. Callers that need to wait for completion should continue to use
wait_complete().Tests
cargo fmt --all -- --checkcargo test -p datafusion-physical-expr dynamic_filter --lib