Default sortMethod (plus: initialState from extra props)

[dahlbyk]

Griddle major version

1.x

Changes proposed in this pull request

• Type cleanup for RowRenderProperties and ColumnRenderProperties, which currently the same as RowDefinitionProps and ColumnDefinitionProps.
• Rearranges how initialState is initialized to accept/override initialState from extra Griddle props. Everything still seems to work as expected, but please double-check this.
  • As a bonus, this allows setting enableSettings and textProperties without a plugin, as demonstrated with new stories.
• Default sortMethod from state is used, if it exists.
• Addressed TODO to get Next/Previous label from textProperties

Why these changes are made

<Griddle sortMethod={...}> now works as a high-level hook to override all columns' sort behavior. It does not change default behavior (cc #466).

Are there tests?

Stories!

[ryanlanciaux]

Ahh shoot -- didn't mean to make conflicts here.

[dahlbyk]

Ahh shoot -- didn't mean to make conflicts here.

It's fine, I knew it was coming.

[dahlbyk]

(Conflicts have been resolved.)

[ryanlanciaux]

Should this have the sortProperties set like the previous story?

const sortProperties = [
  { id: 'name', sortAscending: true }
];
...
<Griddle
  ...
  sortProperties={sortProperties}
  sortMethod={sortBySecondCharacter}>

[dahlbyk]

I don't think this grid needs to be pre-sorted, no. This test is derived from the test that follows.

[ryanlanciaux]

Got it - sorry about my confusion. 👍

[ryanlanciaux]

This looks great! I've run this locally on some of my projects also and everything seems to work well. I just have the one question on the story but it looks good to merge.