feat: Add ability to add Version manually#3
Merged
Conversation
User Story: As a developer I want to be able to define the Version manually. Background: If for example you use CLI on CI level, you probably use Semantic Release (https://www.npmjs.com/package/semantic-release) to define the Versions of the Application. In this case, the versions created by react-native-cli-bump-version and Semantic Release will be different. To be able to use it with SR it will be good to add additional parameter to this CLI
Owner
|
Thanks for the PR! I'm gona review it ASAP |
Grohden
requested changes
Sep 6, 2020
Grohden
left a comment
Grohden
left a comment
Owner
There was a problem hiding this comment.
You also need to change the root react-native.config.js to pass this new flag down
Grohden
approved these changes
Sep 7, 2020
Owner
|
@andreieuganox again, thx for the PR, I'm gonna write tests and soon release it! |
Owner
|
1.0.4 released, feel free to ask me anything in case something is wrong |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
User Story
As a developer I want to be able to define the Version manually.
Background
If for example you use CLI on CI level, you probably use Semantic Release (https://www.npmjs.com/package/semantic-release) to define the Versions of the Application. In this case, the versions created by react-native-cli-bump-version and Semantic Release will be different. To be able to use it with SR it will be good to add additional parameter to this CLI.
P.S. The changes were not tested tbh...sorry for that!
P.S.S. Thank you for your work!