Fix MAC-18 missing from magazines system - #748
Open
Gamaun007 wants to merge 1 commit into
Open
Conversation
The Weapon Pack converts wpn_mac10 from 9x19 (MAC-10) to 9x18 (MAC-18) via mod_system_zzzzz_gamma_mac18.ltx, and its base_mac10.ltx rewrites the [mac10_9x19] base type's caliber from 9x19 to 9x18 to match. However the upstream weapon-magazine lookup (from 487- MAC10 Quality Control) only maps ammo_9x19_fmj -> mac10_9x19, so after the conversion the gun has no base_type binding for its actual ammo and the magazine system silently skips it. Adds w_mac10_mac18.ltx with a DLTX merge override (![wpn_mac10]) supplying the missing ammo_9x18_fmj mapping. Non-destructive: the existing 9x19 and 11.43x23 mappings from the upstream lookup are preserved. Filename sorts alphabetically after the upstream w_mac10.ltx so the override targets a section that already exists. Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
Owner
|
God I hate AI written PR messages |
Author
|
At least AI provided more expertise for 30 minutes comparing to me trying to dig into it for the same amount of time |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The Weapon Pack converts wpn_mac10 from 9x19 (MAC-10) to 9x18 (MAC-18) via mod_system_zzzzz_gamma_mac18.ltx, and its base_mac10.ltx rewrites the [mac10_9x19] base type's caliber from 9x19 to 9x18 to match. However the upstream weapon-magazine lookup (from 487- MAC10 Quality Control) only maps ammo_9x19_fmj -> mac10_9x19, so after the conversion the gun has no base_type binding for its actual ammo and the magazine system silently skips it.
Adds w_mac10_mac18.ltx with a DLTX merge override (![wpn_mac10]) supplying the missing ammo_9x18_fmj mapping. Non-destructive: the existing 9x19 and 11.43x23 mappings from the upstream lookup are preserved. Filename sorts alphabetically after the upstream w_mac10.ltx so the override targets a section that already exists.