Changes to versioning, hardcoded strings, and logic updates#2
Merged
Conversation
added 2 commits
March 2, 2026 12:01
…Edge display capabilities. Additionally, updated gradle scripts to target proper versions and changed SyncService to properly channel for newer versions
GroveOfGraves
approved these changes
Mar 2, 2026
GroveOfGraves
left a comment
GroveOfGraves
left a comment
Owner
There was a problem hiding this comment.
I think this all looks good, as far as I can tell.
ElitheEpicBoss3
added a commit
that referenced
this pull request
Mar 2, 2026
* Moved hardcoded strings to strings.xml and gave many methods Edge-to-Edge display capabilities. Additionally, updated gradle scripts to target proper versions and changed SyncService to properly channel for newer versions * Minor updates and error cleanups --------- Co-authored-by: elith <elith@DESKTOP-9R0HDQ5>
GroveOfGraves
added a commit
that referenced
this pull request
Mar 3, 2026
* Moved hardcoded strings to strings.xml and gave many methods Edge-to-Edge display capabilities. Additionally, updated gradle scripts to target proper versions and changed SyncService to properly channel for newer versions * Minor updates and error cleanups * Updating Edge-to-Edge and various other useful updates :) Signed-off-by: elith <elith@DESKTOP-9R0HDQ5> * Add a service that forwards the necessary ports for the desktop app (#1) * Changes to versioning, hardcoded strings, and logic updates (#2) * Moved hardcoded strings to strings.xml and gave many methods Edge-to-Edge display capabilities. Additionally, updated gradle scripts to target proper versions and changed SyncService to properly channel for newer versions * Minor updates and error cleanups --------- Co-authored-by: elith <elith@DESKTOP-9R0HDQ5> * Feat/foreground service changes (#3) * Initial changes to ensure foreground operation compliancy * Patch out small issues * Stop sync automatically, add content intent from notification * Changing the spacing to give small padding for both sides of the screen and hopefully removing some inconsistency in the UI Signed-off-by: elith <elith@DESKTOP-9R0HDQ5> --------- Signed-off-by: elith <elith@DESKTOP-9R0HDQ5> Co-authored-by: elith <elith@DESKTOP-9R0HDQ5> Co-authored-by: GroveOfGraves <113633048+GroveOfGraves@users.noreply.github.com>
GroveOfGraves
added a commit
that referenced
this pull request
Mar 3, 2026
* Moved hardcoded strings to strings.xml and gave many methods Edge-to-Edge display capabilities. Additionally, updated gradle scripts to target proper versions and changed SyncService to properly channel for newer versions * Minor updates and error cleanups * Updating Edge-to-Edge and various other useful updates :) Signed-off-by: elith <elith@DESKTOP-9R0HDQ5> * Add a service that forwards the necessary ports for the desktop app (#1) * Changes to versioning, hardcoded strings, and logic updates (#2) * Moved hardcoded strings to strings.xml and gave many methods Edge-to-Edge display capabilities. Additionally, updated gradle scripts to target proper versions and changed SyncService to properly channel for newer versions * Minor updates and error cleanups --------- Co-authored-by: elith <elith@DESKTOP-9R0HDQ5> * Feat/foreground service changes (#3) * Initial changes to ensure foreground operation compliancy * Patch out small issues * Stop sync automatically, add content intent from notification * Properly centering the bottom buttons within the bottom section Signed-off-by: elith <elith@DESKTOP-9R0HDQ5> * Added constants for hardcoded values within the project - mainly from menu_record.xml and added to strings.xml (I have been doing this through previous commits) Signed-off-by: elith <elith@DESKTOP-9R0HDQ5> --------- Signed-off-by: elith <elith@DESKTOP-9R0HDQ5> Co-authored-by: elith <elith@DESKTOP-9R0HDQ5> Co-authored-by: GroveOfGraves <113633048+GroveOfGraves@users.noreply.github.com>
GroveOfGraves
added a commit
that referenced
this pull request
Mar 3, 2026
* Moved hardcoded strings to strings.xml and gave many methods Edge-to-Edge display capabilities. Additionally, updated gradle scripts to target proper versions and changed SyncService to properly channel for newer versions * Minor updates and error cleanups * Updating Edge-to-Edge and various other useful updates :) Signed-off-by: elith <elith@DESKTOP-9R0HDQ5> * Add a service that forwards the necessary ports for the desktop app (#1) * Changes to versioning, hardcoded strings, and logic updates (#2) * Moved hardcoded strings to strings.xml and gave many methods Edge-to-Edge display capabilities. Additionally, updated gradle scripts to target proper versions and changed SyncService to properly channel for newer versions * Minor updates and error cleanups --------- Co-authored-by: elith <elith@DESKTOP-9R0HDQ5> * Feat/foreground service changes (#3) * Initial changes to ensure foreground operation compliancy * Patch out small issues * Stop sync automatically, add content intent from notification * Updated hardcoded strings, warnings, and added onTimeout function to handle a service timeout, as well as cleaned up errors in the manifest Signed-off-by: elith <elith@DESKTOP-9R0HDQ5> * Made a ton of updates to deprecated systems including color selection and other fun stuff :) Signed-off-by: elith <elith@DESKTOP-9R0HDQ5> --------- Signed-off-by: elith <elith@DESKTOP-9R0HDQ5> Co-authored-by: elith <elith@DESKTOP-9R0HDQ5> Co-authored-by: GroveOfGraves <113633048+GroveOfGraves@users.noreply.github.com>
GroveOfGraves
added a commit
that referenced
this pull request
Mar 3, 2026
* Moved hardcoded strings to strings.xml and gave many methods Edge-to-Edge display capabilities. Additionally, updated gradle scripts to target proper versions and changed SyncService to properly channel for newer versions * Minor updates and error cleanups * Updating Edge-to-Edge and various other useful updates :) Signed-off-by: elith <elith@DESKTOP-9R0HDQ5> * Add a service that forwards the necessary ports for the desktop app (#1) * Changes to versioning, hardcoded strings, and logic updates (#2) * Moved hardcoded strings to strings.xml and gave many methods Edge-to-Edge display capabilities. Additionally, updated gradle scripts to target proper versions and changed SyncService to properly channel for newer versions * Minor updates and error cleanups --------- Co-authored-by: elith <elith@DESKTOP-9R0HDQ5> * Feat/foreground service changes (#3) * Initial changes to ensure foreground operation compliancy * Patch out small issues * Stop sync automatically, add content intent from notification * Many, many updates to warnings, java standards, and better code for updated versions and cleaner running Signed-off-by: elith <elith@DESKTOP-9R0HDQ5> --------- Signed-off-by: elith <elith@DESKTOP-9R0HDQ5> Co-authored-by: elith <elith@DESKTOP-9R0HDQ5> Co-authored-by: GroveOfGraves <113633048+GroveOfGraves@users.noreply.github.com>
GroveOfGraves
added a commit
that referenced
this pull request
Mar 4, 2026
* Moved hardcoded strings to strings.xml and gave many methods Edge-to-Edge display capabilities. Additionally, updated gradle scripts to target proper versions and changed SyncService to properly channel for newer versions * Minor updates and error cleanups * Updating Edge-to-Edge and various other useful updates :) Signed-off-by: elith <elith@DESKTOP-9R0HDQ5> * Add a service that forwards the necessary ports for the desktop app (#1) * Changes to versioning, hardcoded strings, and logic updates (#2) * Moved hardcoded strings to strings.xml and gave many methods Edge-to-Edge display capabilities. Additionally, updated gradle scripts to target proper versions and changed SyncService to properly channel for newer versions * Minor updates and error cleanups --------- Co-authored-by: elith <elith@DESKTOP-9R0HDQ5> * Feat/foreground service changes (#3) * Initial changes to ensure foreground operation compliancy * Patch out small issues * Stop sync automatically, add content intent from notification * Many, many updates to warnings, java standards, and better code for updated versions and cleaner running Signed-off-by: elith <elith@DESKTOP-9R0HDQ5> * Many warnings fixed plus addition of FloatPreference.java, which handles some issues with how floats were being handled Signed-off-by: elith <elith@DESKTOP-9R0HDQ5> * Fixed problems with merge (oops) Signed-off-by: elith <elith@DESKTOP-9R0HDQ5> * Fixing various warnings throughout files Signed-off-by: elith <elith@DESKTOP-9R0HDQ5> --------- Signed-off-by: elith <elith@DESKTOP-9R0HDQ5> Co-authored-by: elith <elith@DESKTOP-9R0HDQ5> Co-authored-by: GroveOfGraves <113633048+GroveOfGraves@users.noreply.github.com>
GroveOfGraves
added a commit
that referenced
this pull request
Mar 5, 2026
* Moved hardcoded strings to strings.xml and gave many methods Edge-to-Edge display capabilities. Additionally, updated gradle scripts to target proper versions and changed SyncService to properly channel for newer versions * Minor updates and error cleanups * Updating Edge-to-Edge and various other useful updates :) Signed-off-by: elith <elith@DESKTOP-9R0HDQ5> * Add a service that forwards the necessary ports for the desktop app (#1) * Changes to versioning, hardcoded strings, and logic updates (#2) * Moved hardcoded strings to strings.xml and gave many methods Edge-to-Edge display capabilities. Additionally, updated gradle scripts to target proper versions and changed SyncService to properly channel for newer versions * Minor updates and error cleanups --------- Co-authored-by: elith <elith@DESKTOP-9R0HDQ5> * Feat/foreground service changes (#3) * Initial changes to ensure foreground operation compliancy * Patch out small issues * Stop sync automatically, add content intent from notification * Fixing various warnings throughout files caused by the merge, as well as changing deprecated functions Signed-off-by: elith <elith@DESKTOP-9R0HDQ5> --------- Signed-off-by: elith <elith@DESKTOP-9R0HDQ5> Co-authored-by: elith <elith@DESKTOP-9R0HDQ5> Co-authored-by: GroveOfGraves <113633048+GroveOfGraves@users.noreply.github.com>
GroveOfGraves
added a commit
that referenced
this pull request
Mar 5, 2026
* Moved hardcoded strings to strings.xml and gave many methods Edge-to-Edge display capabilities. Additionally, updated gradle scripts to target proper versions and changed SyncService to properly channel for newer versions * Minor updates and error cleanups * Updating Edge-to-Edge and various other useful updates :) Signed-off-by: elith <elith@DESKTOP-9R0HDQ5> * Add a service that forwards the necessary ports for the desktop app (#1) * Changes to versioning, hardcoded strings, and logic updates (#2) * Moved hardcoded strings to strings.xml and gave many methods Edge-to-Edge display capabilities. Additionally, updated gradle scripts to target proper versions and changed SyncService to properly channel for newer versions * Minor updates and error cleanups --------- Co-authored-by: elith <elith@DESKTOP-9R0HDQ5> * Feat/foreground service changes (#3) * Initial changes to ensure foreground operation compliancy * Patch out small issues * Stop sync automatically, add content intent from notification * Fixing various warnings throughout files, making lambda functions, and cleaning up some unused functions and variables Signed-off-by: elith <elith@DESKTOP-9R0HDQ5> --------- Signed-off-by: elith <elith@DESKTOP-9R0HDQ5> Co-authored-by: elith <elith@DESKTOP-9R0HDQ5> Co-authored-by: GroveOfGraves <113633048+GroveOfGraves@users.noreply.github.com>
GroveOfGraves
added a commit
that referenced
this pull request
Mar 6, 2026
* Moved hardcoded strings to strings.xml and gave many methods Edge-to-Edge display capabilities. Additionally, updated gradle scripts to target proper versions and changed SyncService to properly channel for newer versions * Minor updates and error cleanups * Updating Edge-to-Edge and various other useful updates :) Signed-off-by: elith <elith@DESKTOP-9R0HDQ5> * Add a service that forwards the necessary ports for the desktop app (#1) * Changes to versioning, hardcoded strings, and logic updates (#2) * Moved hardcoded strings to strings.xml and gave many methods Edge-to-Edge display capabilities. Additionally, updated gradle scripts to target proper versions and changed SyncService to properly channel for newer versions * Minor updates and error cleanups --------- Co-authored-by: elith <elith@DESKTOP-9R0HDQ5> * Feat/foreground service changes (#3) * Initial changes to ensure foreground operation compliancy * Patch out small issues * Stop sync automatically, add content intent from notification * Making a lot of changes to clean up warnings and errors in the IDE, making sure to avoid Test files as they were being worked on by others Signed-off-by: elith <elith@DESKTOP-9R0HDQ5> * Cleaned up the merge :) Signed-off-by: elith <elith@DESKTOP-9R0HDQ5> --------- Signed-off-by: elith <elith@DESKTOP-9R0HDQ5> Co-authored-by: elith <elith@DESKTOP-9R0HDQ5> Co-authored-by: GroveOfGraves <113633048+GroveOfGraves@users.noreply.github.com>
GroveOfGraves
added a commit
that referenced
this pull request
Mar 6, 2026
* Moved hardcoded strings to strings.xml and gave many methods Edge-to-Edge display capabilities. Additionally, updated gradle scripts to target proper versions and changed SyncService to properly channel for newer versions * Minor updates and error cleanups * Updating Edge-to-Edge and various other useful updates :) Signed-off-by: elith <elith@DESKTOP-9R0HDQ5> * Add a service that forwards the necessary ports for the desktop app (#1) * Changes to versioning, hardcoded strings, and logic updates (#2) * Moved hardcoded strings to strings.xml and gave many methods Edge-to-Edge display capabilities. Additionally, updated gradle scripts to target proper versions and changed SyncService to properly channel for newer versions * Minor updates and error cleanups --------- Co-authored-by: elith <elith@DESKTOP-9R0HDQ5> * Feat/foreground service changes (#3) * Initial changes to ensure foreground operation compliancy * Patch out small issues * Stop sync automatically, add content intent from notification * Fixed the last of the warnings and feelin GOOD Signed-off-by: elith <elith@DESKTOP-9R0HDQ5> * I just trying to fix the scan screen Signed-off-by: elith <elith@DESKTOP-9R0HDQ5> * I fixed it Signed-off-by: elith <elith@DESKTOP-9R0HDQ5> --------- Signed-off-by: elith <elith@DESKTOP-9R0HDQ5> Co-authored-by: elith <elith@DESKTOP-9R0HDQ5> Co-authored-by: GroveOfGraves <113633048+GroveOfGraves@users.noreply.github.com>
Major-Q
pushed a commit
that referenced
this pull request
Mar 6, 2026
* Moved hardcoded strings to strings.xml and gave many methods Edge-to-Edge display capabilities. Additionally, updated gradle scripts to target proper versions and changed SyncService to properly channel for newer versions * Minor updates and error cleanups * Updating Edge-to-Edge and various other useful updates :) Signed-off-by: elith <elith@DESKTOP-9R0HDQ5> * Add a service that forwards the necessary ports for the desktop app (#1) * Changes to versioning, hardcoded strings, and logic updates (#2) * Moved hardcoded strings to strings.xml and gave many methods Edge-to-Edge display capabilities. Additionally, updated gradle scripts to target proper versions and changed SyncService to properly channel for newer versions * Minor updates and error cleanups --------- Co-authored-by: elith <elith@DESKTOP-9R0HDQ5> * Feat/foreground service changes (#3) * Initial changes to ensure foreground operation compliancy * Patch out small issues * Stop sync automatically, add content intent from notification * Fixed the last of the warnings and feelin GOOD Signed-off-by: elith <elith@DESKTOP-9R0HDQ5> * Changing the banner and the background for sync activity and made the banner static Signed-off-by: elith <elith@DESKTOP-9R0HDQ5> * Changing the banner and the background for sync activity and made the banner static Signed-off-by: elith <elith@DESKTOP-9R0HDQ5> --------- Signed-off-by: elith <elith@DESKTOP-9R0HDQ5> Co-authored-by: elith <elith@DESKTOP-9R0HDQ5> Co-authored-by: GroveOfGraves <113633048+GroveOfGraves@users.noreply.github.com>
Major-Q
pushed a commit
that referenced
this pull request
Mar 6, 2026
* Moved hardcoded strings to strings.xml and gave many methods Edge-to-Edge display capabilities. Additionally, updated gradle scripts to target proper versions and changed SyncService to properly channel for newer versions * Minor updates and error cleanups * Updating Edge-to-Edge and various other useful updates :) Signed-off-by: elith <elith@DESKTOP-9R0HDQ5> * Add a service that forwards the necessary ports for the desktop app (#1) * Changes to versioning, hardcoded strings, and logic updates (#2) * Moved hardcoded strings to strings.xml and gave many methods Edge-to-Edge display capabilities. Additionally, updated gradle scripts to target proper versions and changed SyncService to properly channel for newer versions * Minor updates and error cleanups --------- Co-authored-by: elith <elith@DESKTOP-9R0HDQ5> * Feat/foreground service changes (#3) * Initial changes to ensure foreground operation compliancy * Patch out small issues * Stop sync automatically, add content intent from notification * Fixed the last of the warnings and feelin GOOD Signed-off-by: elith <elith@DESKTOP-9R0HDQ5> * Why won't the status bar change Signed-off-by: elith <elith@DESKTOP-9R0HDQ5> * I FIXED IT WOOOOOOOOOO Signed-off-by: elith <elith@DESKTOP-9R0HDQ5> --------- Signed-off-by: elith <elith@DESKTOP-9R0HDQ5> Co-authored-by: elith <elith@DESKTOP-9R0HDQ5> Co-authored-by: GroveOfGraves <113633048+GroveOfGraves@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I cleaned up some fun stuff, including initial versioning and changing some hardcoded strings into variables, as well as cleaning up some logic to make more sense (solo switch statement to an if statement)