Fix incorrect matching of Express/Mocha keywords.#11
Merged
cooncesean merged 1 commit intoGuidebook:masterfrom May 22, 2017
Merged
Fix incorrect matching of Express/Mocha keywords.#11cooncesean merged 1 commit intoGuidebook:masterfrom
cooncesean merged 1 commit intoGuidebook:masterfrom
Conversation
Contributor
|
Thanks Zach 👍 |
Contributor
Author
|
No problem! Thanks for promptly merging 😄 |
Contributor
Author
|
Hey @cooncesean -- sorry to bug you, any chance you could create a new release & update package control? 😄 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I first noticed this incorrect syntax highlighting:
which I then noticed will generally match incorrectly whenever one of the keywords appears with 1+ spaces in front of it:
I traced the problem to this rule. While researching what that rule does, I found the same rule here in
sublime-better-coffeescript-- I assumesublime-cjsxis a derivative of that project.sublime-better-coffeescripthad the tweak to the rule that I'm submitting in this PR, which seems to fix the problem:PS: after merging (if this looks good), could y'all cut a new release on Package Control? I don't think that ever got done after my previous contributions :) thanks!