fix: declare engines.node>=20 (drop stale engines.bun) - #63
Merged
Conversation
Published manifest declared engines.bun: ">=1.3.0" but no engines.node, making npm warn on Node installs while the code itself uses only node:fs, node:fs/promises, node:readline and node:path — no Bun-specific API anywhere in src/ or dist/. Root cause: leftover from the `bun init` template. tsdown already targets node20, but the engines field never got updated to match. Fix: replace engines.bun with engines.node: ">=20". Node 20 is the current active LTS and covers all APIs used (all stable since Node 14). Bun reads engines.node and remains compatible for the dev workflow. Verified end-to-end with npm pack + install from real tarball in a clean Node v25 project: all 4 exports (readSessionIds, readSession, readSessionTurns, readSubagentTurns) work against real session data.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
engines.bun: ">=1.3.0"withengines.node: ">=20"inpackage.json— the package source uses only Node-native APIs (node:fs,node:fs/promises,node:readline,node:path); no Bun-specific API anywhere insrc/ordist/.bun inittemplate.tsdown.config.tsalready targetsnode20, but theenginesfield never got updated to match.engines.nodeand remains fully compatible for the dev workflow.Why Node 20
Current active LTS. All APIs used in the parser have been stable since Node 14, so this bound is conservative.
Test plan
bun run check(biome) — 47 files, no issuebun run typecheck— cleanbun test— 97 pass / 0 fail / 100% coveragebun run build— dist cleannpm pack+ install of real tarball in a clean Node v25 project — all 4 exports (readSessionIds,readSession,readSessionTurns,readSubagentTurns) work against real session data