解决导出 MCBBS 整合包因文件过多导致的 Out Of Memory - #6630
Merged
Merged
Conversation
Member
|
@codex review |
|
Codex Review: Didn't find any major issues. What shall we delve into next? Reviewed commit: ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
If Codex has suggestions, it will comment; otherwise it will react with 👍. Codex can also answer questions or update the PR. Try commenting "@codex address that feedback". |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
#6086 #6173
导出 MCBBS 整合包时，
mcbbs.packmeta会记录整合包中的文件信息。原实现会先将整个McbbsModpackManifest序列化为 JSON 字符串，再由Zipper.putTextFile将该字符串转换为完整的 UTF-8 字节数组，导致内存中同时存在完整的 JSON 字符串和字节数组。文件数量较多时，生成的清单 JSON 会过大，并可能导致 OOM。此 PR 将
mcbbs.packmeta直接序列化并写入 ZIP，避免创建完整的中间 JSON 字符串和 UTF-8 字节数组，降低导出过程的内存峰值。