Skip to content

Fix trafficnow filtering - #5896

Merged
hjvuor merged 5 commits into
v3from
fix-trafficnow-filtering
Aug 5, 2026
Merged

Fix trafficnow filtering#5896
hjvuor merged 5 commits into
v3from
fix-trafficnow-filtering

Conversation

@sharhio

@sharhio sharhio commented Jul 31, 2026

Copy link
Copy Markdown
Contributor

Proposed Changes

  • When single alerts are split into mode specific cards the mode filtering was not applied correctly and unwanted mode cards were shown. Splitting now takes into account the selected filters.
  • Also did some refactoring and added tests

Pull Request Check List

  • A reasonable set of unit tests is included
  • Console does not show new warnings/errors
  • Changes are documented or they are self explanatory
  • This pull request does not have any merge conflicts
  • All existing tests pass in CI build

Review

  • Read and verify the code changes
  • Test the functionality by running the UI locally with all popular browsers available in your platform
  • Check that the implementation matches the design, when such one is defined in an issue in Azure Boards
  • Merge the pull request

@hjvuor hjvuor left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Filtering by mode works now but if searching for a specific route or just favorite routes the duplicate cards for other modes are shown.

@hjvuor hjvuor left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think this might've been an already existing bug but the bus filter seems to leave out bus-local and bus-express entities (might probably also be bugged for speedtrams and replacement buses but couldn't verify quickly). modeUtils.js contains the getRouteMode function that has the correct mapping but it does not seem like such is used anywhere in the trafficnow page.

@hjvuor
hjvuor self-requested a review August 5, 2026 05:18
@hjvuor
hjvuor merged commit e826a8f into v3 Aug 5, 2026
7 checks passed
@hjvuor
hjvuor deleted the fix-trafficnow-filtering branch August 5, 2026 05:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants