Fix trafficnow filtering - #5896
Merged
Merged
Conversation
hjvuor
requested changes
Jul 31, 2026
hjvuor
left a comment
Contributor
There was a problem hiding this comment.
Filtering by mode works now but if searching for a specific route or just favorite routes the duplicate cards for other modes are shown.
hjvuor
requested changes
Aug 3, 2026
hjvuor
left a comment
Contributor
There was a problem hiding this comment.
I think this might've been an already existing bug but the bus filter seems to leave out bus-local and bus-express entities (might probably also be bugged for speedtrams and replacement buses but couldn't verify quickly). modeUtils.js contains the getRouteMode function that has the correct mapping but it does not seem like such is used anywhere in the trafficnow page.
hjvuor
self-requested a review
August 5, 2026 05:18
hjvuor
approved these changes
Aug 5, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Proposed Changes
Pull Request Check List
Review