Sanitize before inserting variables to innerHTML#83
Open
Conversation
Contributor
|
From my testing on Firefox 105.0.1 (64-bit) appears to be have been working. The three issues are:
Tested:
All tested on default options but did open up on large text no avatar to confirm these options work too. |
Contributor
|
From my testing on 105.0.5151.0 (Developer Build) (64-bit) appears to be have been working.
Tested:
All tested on default options but did open up on large text no avatar to confirm these options work too. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
We received this notice from Mozilla Add-ons:
To comply with the request, this PR adds calls to
DOMPurify.sanitize()to strip any potentially problematic data from the variables being included in theinnerHTMLelement on line 652 of chat_inPage.js.