V11 compatibility problem with scenes

[Quick67]

Hello,

I really love this module. I would like to use it with VTT V11 but I'm not able to convert scenes.

Actors and compendiums have still the button to run the script and they are correctly converted.

I'm not able to convert scene anymore.

Thank you!

[HadaIonut]

hello, thanks for using the module but sadly i am not supporting any of my foundry modules any more. If you find any other dev willing and able to continue the development please feel free to send them my way, I can help them pick up the module.

I will leave this issue open as future documentation

[Quick67]

Thank you for the answer. It is sad indeed as this module is fantastic for those who like to play in meters.
I don't know any dev that may be interested. I hope someone may read this post in the future and help.

Anyway, I think that I found the solution for reaching compatibility in V11. Your module still rock.

MetricModule.js in line #63 and below use "app?.options?.id" that doesn't work anymore. the right now seems to be "app.id;"

OLD CODE WAS:

const onRenderSideBar = (app, html) => {
    if (!game.user.hasRole(4)) return;
    let button = $(`<button><i class='fas fa-exchange-alt'></i>Metrify all the ${app?.options?.id}</button>`);
    const type = app?.options?.id;
    if (batchCompendiumUpdaterMap[game.system.id][type])
        batchCompendiumUpdaterMap[game.system.id][type](type === 'compendium' ? game.packs.keys() : game[type], type, button);
    if (app?.options?.id !== 'combat' && app?.options?.id !== 'playlists' && !app?.options?.id.includes('popout')) {
        html.find(".directory-footer").append(button);
        html.find(".directory-footer").removeClass('action-buttons')
    }

}

The correct working one now is

const onRenderSideBar = (app, html) => {
    if (!game.user.hasRole(4)) return;   
    const type = app.id;
    let button = $(`<button><i class='fas fa-exchange-alt'></i>Metrify all the ${type}</button>`);
    
    if (batchCompendiumUpdaterMap[game.system.id][type])

        batchCompendiumUpdaterMap[game.system.id][type](type === 'compendium' ? game.packs.keys() : game[type], type, button);

    if (type !== 'combat' && type !== 'playlists' && !type.includes('popout')) {
        html.find(".directory-footer").append(button);
        html.find(".directory-footer").removeClass('action-buttons')
    }
}

[willumz]

Hi @HadaIonut, hope you're doing well!

I've made this fix and generally fixed up the repository in my fork (https://github.com/willumz/foundry-mgl).

If you truly are done with this project, then I was wondering whether it might make sense to link to my fork in the README, where I intend (for the moment, at least) to keep it up to date and working).

[HadaIonut]

@willumz Done. I think there is a way i can make the module on the foundry store point to yours as well if you want to.

[willumz]

Thanks! It would probably be worth exploring altering the Foundry listing as well - I had to change the module ID on my fork to stop it from conflicting. Do you know if I'd have to change the ID back on my fork or whether you can change the ID attached to the listing as well?

[HadaIonut]

Update: I cannot figure out the foundry interface I dont think I can even delist the module sadly (if you want to continue this conversation please contact me on discord: assassinduke)