[Mode] Hyrule Warriors-style Link#665
Conversation
|
@OtherBlue nice work! Is your intent to have this merged upstream or just have a place to host it? If the latter you can follow the |
|
Personally, I would love to see this making it's way to the main build Good job buddy! |
|
I'm thinking of opening the PR to the main build now Wasn't the original intention but it's probably more convenient anyway Just gotta figure out why clang-format is failing ig |
inspectredc
left a comment
inspectredc
left a comment
There was a problem hiding this comment.
Looks Great! Just a couple things
There was a problem hiding this comment.
I think it'd be easier to understand what this is doing if we write it out in full
| RegisterHWStyledLink(); | |
| RegisterHyruleWarriorsStyledLink(); |
There was a problem hiding this comment.
Oh yeah, absolutely, just old habits still sticking around haha
| Matrix_RotateYS(14563, MTXMODE_APPLY); | ||
| Matrix_RotateZS(-4854, MTXMODE_APPLY); |
There was a problem hiding this comment.
Matrix_RotateYS and Matrix_RotateZS use 'binangs' (binary angles). Would it be alright to write this as hex?
Alternatively, write it in degrees and use the DEG_TO_BINANG(angle) macro
There was a problem hiding this comment.
tbh these first values were put in there by Proxy, I'll look into converting them tho
|
Alrighty, final(?) changes made |
OtherBlue
force-pushed
the
HW-Styled-Link
branch
from
671e6d2 to
fa702ed
Compare
…arkinian into HW-Styled-Link
|
Closed this by mistake, it's not going anywhere, my bad |
dealing with a crash on my machine, gotta figure out what's up with that
…arkinian into HW-Styled-Link
Ok, I think that's just about everything once again, should be ready to go
OtherBlue
changed the title
garrettjoecox
left a comment
garrettjoecox
left a comment
There was a problem hiding this comment.
Had been holding off on this one because I wasn't sure how I felt about it as an actual code addition, but it's well isolated so let's do it.
|
OtherBlue:HW-Styled-Link |
6 participants
Adds an option to place the Keaton and Fierce Deity masks similarly to how they are placed on Young Link in Hyrule Warriors once they are acquired in-game.
Branches off #537 for the "OnPlayerPostLimbDraw" hook
Build Artifacts