[Enhancement] Adds options for when the deku palace guard search balls will appear#866
Merged
Archez merged 5 commits intoHarbourMasters:developfrom Nov 26, 2024
Merged
Conversation
Archez
reviewed
Nov 18, 2024
Contributor
|
Code wise I think this is in a good spot. Regarding Restorations vs Difficulty Options in the menu, I think I am leaning towards this being moved to Difficulty Options. That would also align with a similar setting in SoH for the child stealth guard search balls. |
garrettjoecox
approved these changes
Nov 26, 2024
Contributor
garrettjoecox
left a comment
garrettjoecox
left a comment
There was a problem hiding this comment.
I also think difficulty options makes more sense 👍 otherwise LGTM great work
Contributor
Author
|
I have moved the this enhancement to difficulty options as requested. |
lscholte
force-pushed
the
deku-guard-search-balls
branch
from
3816ec1 to
d93a939
Compare
…into deku-guard-search-balls # Conflicts: # mm/2s2h/GameInteractor/GameInteractor.h
Archez
approved these changes
Nov 26, 2024
4 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This addresses #860
I have added 3 options for when the deku palace guard search balls will appear:
I am not sure if this belongs under restorations or elsewhere. It also kinda feels like it could fit under difficulty options.
Build Artifacts