Add IgnoreActorMtx for interpolation and fix bunny hood + other interpolation issues#873
Merged
louist103 merged 1 commit intoHarbourMasters:develop-satokofrom Nov 24, 2024
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
With our interpolation system, for each actor we track their starting matrix and then each child interpolation path applies matrix calculations against that matrix.
For whatever reason, bunny hood does not like this. So I've added a new method
FrameInterpolation_IgnoreActorMtx()that allows us to specify for the current interpolation record child to skip using the actor matrix. Upon closing the record child, the flag will become unset. This fixes the bunny hood jumping with interpolation when changing links position abruptly.I don't really understand what the actor matrix specific handling does, but I know removing it is not good as then link will look flat when changing 180º
Fixes #412
Build Artifacts