Fix invalid menu name in rumble testing#905
Fix invalid menu name in rumble testing#905Archez merged 2 commits intoHarbourMasters:develop-satokofrom
Conversation
|
As a fix, I think this would be better rebased and pointed to the |
lightmanLP
force-pushed
the
fix/invalid-menu
branch
from
4863103 to
b0dad84
Compare
| controllerConfigWindow = std::dynamic_pointer_cast<BenInputEditorWindow>( | ||
| Ship::Context::GetInstance()->GetWindow()->GetGui()->GetGuiWindow("Input Editor")); | ||
| Ship::Context::GetInstance()->GetWindow()->GetGui()->GetGuiWindow("2S2H Input Editor")); |
There was a problem hiding this comment.
@briaguya-ai I just noticed the code that uses this window fetch is commented out (for bailing out of rumble if the input editor was actively testing rumble). SoH does not have this commented out.
If it is not needed at all then I think this code can just be removed all together. Especially considering that rumble could be tested on a port that isn't port 1.
There was a problem hiding this comment.
i was quite confused as to how this got to be this way. it looks like it was commented out back when we were using the upstream LUS input editor window 782c51c which doesn't have rumble testing support.
since the 2ship input editor is based off the ship input editor, we should be able to uncomment that part
3 participants
Input Editor->LUS::InputEditorWindow2S2H Input Editor->BenInputEditorWindowBuild Artifacts