docs: fix RouteMatrixElement duration return types#1
Open
HariNayan wants to merge 1 commit into
Open
Conversation
Fixes googleapis#16522 Updated the RouteMatrixElement documentation to reflect that duration and static_duration are returned as datetime.timedelta objects at runtime rather than google.protobuf.duration_pb2.Duration.
1 task
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What kind of change does this PR introduce?
docs
What is the current behavior?
Fixes googleapis#16522 —
RouteMatrixElement.durationandstatic_durationare documented as
google.protobuf.duration_pb2.Durationbut returndatetime.timedeltaat runtime due to proto-plus marshalling.What is the new behavior?
Documentation now correctly reflects
datetime.timedeltaas the return type.