chore(renovate): group pre-1.0 dprint/oxfmt bumps with non-major deps - #28
Merged
Conversation
Under caret semantics ^0.x doesn't satisfy the next 0.y, so Renovate splits every pre-1.0 dprint/oxfmt bump into its own PR. These formatters are stable in practice and breakage surfaces immediately in tooling, so group them with the other non-major updates until they reach 1.0.0. Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
There was a problem hiding this comment.
Code Review
This pull request updates the Renovate configuration to group pre-1.0 updates of dprint and oxfmt with other non-major dependencies. The review feedback correctly points out that minor version bumps for pre-1.0 dependencies are classified as major updates in Renovate, meaning "major" must be added to the matchUpdateTypes array for the rule to work as intended.
Renovate classifies a 0.x minor bump (e.g. 0.58.0 -> 0.59.0) as a major update under semver, so restricting matchUpdateTypes to [minor, patch] missed exactly the bumps we want to group. Drop the restriction; matchCurrentVersion < 1.0.0 already scopes the rule to pre-1.0. Addresses Gemini review feedback. Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
|
🎉 This PR is included in version 1.2.2 🎉 The release is available on: Your semantic-release bot 📦🚀 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
Treat pre-1.0
dprint/oxfmtbumps as non-major, so they group into the existing "all non-major dependencies" PR instead of opening a separate PR every release.Why
Under caret semantics
^0.58.0doesn't satisfy0.59.0, so Renovate splits every0.xminor bump of these formatters into its own PR (e.g. the standalone oxfmt/dprint PRs this week). They're stable in practice and any breakage surfaces immediately in the formatter tooling — no need for individual review.How
Adds a
packageRulesentry mirroring the existing non-major group, scoped todprint/oxfmtwhilematchCurrentVersion: "< 1.0.0". Once either reaches 1.0.0 the rule stops matching and they return to the normal major cadence (separate PRs) automatically. Validated withrenovate-config-validator.Companion PRs applied to the other repos carrying these tools (schema-codegen, agent-tools, create-harper, studio).
🤖 Generated with Claude Code