feat: Externalize skills into harperfast/skills - #58
Merged
Conversation
dawsontoth
marked this pull request as ready for review
February 26, 2026 21:13
cap10morgan
approved these changes
Feb 26, 2026
|
🎉 This PR is included in version 1.3.0 🎉 The release is available on GitHub release Your semantic-release bot 📦🚀 |
dawsontoth
added a commit
that referenced
this pull request
Jul 24, 2026
…s#57/#58) Re-instates `prebuilt: true` + build-first scripts, reversing f8e4e35. That commit dropped prebuilt assuming @harperfast/nextjs 2.2.2's build-lock (#52) made the on-startup server build viable — but re-testing on a real cluster (stage, Harper 5.1.23) shows the server-side build still fails, regardless of Harper version or bundler: - Turbopack (Next 16 default): `next build` crashes the instant it runs inside a Harper worker thread — `uncaughtException: Worker creator already registered` → build aborts, no .next, app 404s/500s. Filed HarperFast/nextjs#57. - `bundler: webpack`: no crash, but a cold build overruns Harper's 30s `handleApplication` timeout → component load aborts. Filed HarperFast/nextjs#58. - `prebuilt: true`: works — verified live on stage (serves + atomic increment persists across the replicated cluster). Local `harper run`/`dev` and CI stay green because a plain-CLI `next build` (not inside a Harper worker thread) succeeds; only a multi-thread cluster hits the crash. - config.yaml: `prebuilt: true`; comment cites #57/#58 (not the fixed #52). - scripts: `dev`/`start`/`deploy` prefix `next build` again. - nextSmoke.js: build the app if `.next` is absent (harper run serves prebuilt, it won't build on startup); wording updated. Verified locally on 5.1.22. Catalog unchanged — studio: false stays (without an on-cluster build the plugin is a poor Studio experience). Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
dawsontoth
added a commit
that referenced
this pull request
Jul 27, 2026
…s#57/#58) Re-instates `prebuilt: true` + build-first scripts, reversing f8e4e35. That commit dropped prebuilt assuming @harperfast/nextjs 2.2.2's build-lock (#52) made the on-startup server build viable — but re-testing on a real cluster (stage, Harper 5.1.23) shows the server-side build still fails, regardless of Harper version or bundler: - Turbopack (Next 16 default): `next build` crashes the instant it runs inside a Harper worker thread — `uncaughtException: Worker creator already registered` → build aborts, no .next, app 404s/500s. Filed HarperFast/nextjs#57. - `bundler: webpack`: no crash, but a cold build overruns Harper's 30s `handleApplication` timeout → component load aborts. Filed HarperFast/nextjs#58. - `prebuilt: true`: works — verified live on stage (serves + atomic increment persists across the replicated cluster). Local `harper run`/`dev` and CI stay green because a plain-CLI `next build` (not inside a Harper worker thread) succeeds; only a multi-thread cluster hits the crash. - config.yaml: `prebuilt: true`; comment cites #57/#58 (not the fixed #52). - scripts: `dev`/`start`/`deploy` prefix `next build` again. - nextSmoke.js: build the app if `.next` is absent (harper run serves prebuilt, it won't build on startup); wording updated. Verified locally on 5.1.22. Catalog unchanged — studio: false stays (without an on-cluster build the plugin is a poor Studio experience). Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This pivots us to utilize https://github.com/HarperFast/skills, removing the skills from this repository.