Fix cherry-pick workflow: stash sticky-comment helper before branch switch - #178
Merged
Conversation
…branch The Cherry-pick step runs `git checkout -B <branch> origin/<release>`, which swaps the working tree to the release branch. That branch doesn't contain `.github/scripts/upsert-sticky-comment.js`, so every subsequent invocation fails with MODULE_NOT_FOUND. Copy the helper into `$RUNNER_TEMP` right after the `main` checkout and reference it from there in all call sites. Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
Contributor
|
Reviewed; no blockers found. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
The cherry-pick workflow checks out
maininitially so the.github/scripts/upsert-sticky-comment.jshelper (added in #151) is in the tree, but the Cherry-pick step then runsgit checkout -B <branch> origin/<release>and swaps the working tree to the release branch. The release branch (v5.0) doesn't contain that helper, so every subsequentnode .github/scripts/upsert-sticky-comment.jscall fails withMODULE_NOT_FOUND— see run 26107620269.Fix: copy the helper into
$RUNNER_TEMPright after themaincheckout, and invoke it via$UPSERT_STICKYin all four call sites. That path survives the branch switch.report-cherry-pick-tests.ymldoesn't switch branches, so no change there.Test plan
patchand confirm the sticky comment is posted (no MODULE_NOT_FOUND).🤖 Generated with Claude Code