Migrate config and bin unit tests - #117
Merged
Merged
Conversation
cap10morgan
force-pushed
the
tests/lots-of-unit-tests
branch
from
January 23, 2026 22:51
9ceed1d to
1179e38
Compare
...instead of using the --enable-source-maps arg in every test script
cap10morgan
force-pushed
the
tests/lots-of-unit-tests
branch
from
January 23, 2026 22:53
1179e38 to
f4f31cc
Compare
Merged
cap10morgan
changed the title
cap10morgan
marked this pull request as ready for review
January 28, 2026 17:59
|
Review the following changes in direct dependencies. Learn more about Socket for GitHub.
|
kriszyp
approved these changes
Jan 28, 2026
dawsontoth
approved these changes
Jan 29, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR targets
mainto landalmost all of thetheconfigandbinunit tests that the team has prepared for migration.I'll bring over almost all of the rest in one or more future PRs. There's still a little more work some of them need and some other improvements I'm hoping to land.
The only ones we're not bringing over right now are the API unit tests, as they need substantial reworking for rocksdb anyway.
I had to modify a couple of
bintests that had some assertions that didn't seem quite right.