test: investigate Bun concurrency flake in terminology tests (closed — no fix needed) - #1278
Closed
kriszyp wants to merge 2 commits into
Closed
test: investigate Bun concurrency flake in terminology tests (closed — no fix needed)#1278kriszyp wants to merge 2 commits into
kriszyp wants to merge 2 commits into
Conversation
Bun's node:test implementation can run tests within a suite concurrently. csv_data_load jobs stall on Bun (known issue), blocking the Harper instance while concurrent drop_table tests fire against the same server — causing 500 failures and cascading suite timeouts. Setting concurrency: false on the suite guarantees sequential execution, matching the assumed serial ordering of the tests. Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
Contributor
|
Warning You have reached your daily quota limit. Please wait up to 24 hours and I will start processing your requests again! |
Contributor
|
Reviewed; no blockers found. |
The concurrency: false option on the suite caused "Column family already dropped!" failures on Node.js v22, v26, and Windows (all passing on main without the option). The Bun failures in #1236 are pre-existing flakes: the terminology test passes on main including all Bun shards. Closing investigation — no change needed here; re-run when Bun flakes. Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
kriszyp
changed the title
Member
Author
|
Closing — investigation complete, no change needed. The Bun failures in #1236 are pre-existing flakes that pass on main. The concurrency:false approach broke Node.js v22/v26/Windows. Re-run CI when Bun flakes on future PRs. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Investigation into Bun concurrency flake in
Terminology aliasesintegration suite.Finding: The flake is not reproducible on
main— the terminology test passes on all Bun shards on the base branch. The failures observed in #1236 and renovate/eventsource-4.x were occasional Bun flakes, not a structural concurrency bug.What was tried: Added
{ concurrency: false }to the suite to force serial test execution. This fixed the Bun failures but introduced"Column family already dropped!"errors on Node.js v22, v26, and Windows (all passing on main without the option). The option interacts with Node.js's node:test suite lifecycle in a way that corrupts the RocksDB table state.Outcome: Reverted. No change is needed to this test — re-run when Bun flakes.
Separate issue (real regression):
@sinonjs/samsam 9→10(viasinon 21.0.3→21.1.2in #771) broke the update module unit tests — needs investigation before that renovate PR can merge.🤖 Generated with Claude Code