Allow Map methods to be overriden with frozen intrinsics - #308
Merged
Conversation
kriszyp
marked this pull request as ready for review
March 31, 2026 21:25
DavidCockerill
approved these changes
Apr 1, 2026
kriszyp
pushed a commit
that referenced
this pull request
Jun 21, 2026
The dependent rocksdb-js Verification Table PR (#526) landed and published as 2.2.0, so update the dependency from ^1.4.0 and reconcile main's drift. Conflict resolutions: - package.json: rocksdb-js ^2.2.0, lmdb 3.5.5 (main), keep weak-lru-cache ^1.2.2 - DatabaseTransaction.commit: keep coordinated RETRY_NOW_VALUE retry path while adopting main's robust onCommit error handling, ERR_TRY_AGAIN retry (#308), and capped backoff (MAX_RETRY_DELAY_MS) - RecordEncoder.handleLocalTimeForGets: keep the PrimaryRocksDatabase early-return (LMDB-only read-txn tracking) and fold in main's `if (this.isDone) return` guard Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
4 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Vite likes to override Map methods.