-
Notifications
You must be signed in to change notification settings - Fork 1
fix: withOAuthValidation reads request from getContext() (closes #33) #48
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from all commits
Commits
Show all changes
17 commits
Select commit
Hold shift + click to select a range
bb9de21
fix: withOAuthValidation reads request from getContext() (closes #33)
heskew 03f54fc
fix: fail-closed when requireAuth is true and no context is available
heskew 0a5568a
fix: stop calling onValidationError without a request; fix stale v4 J…
heskew 3a4fb45
fix: JSDoc now shows instance-wrap pattern; test no-context callback …
heskew baedb5f
refactor!: withOAuthValidation wraps a Resource class, not an instance
heskew 7fe7d81
fix: onValidationError sees un-mutated request; cover put/patch/delete
heskew a81fb40
fix: re-export withOAuthValidation from package entry; explicit prop …
heskew db072d5
test: cover getOAuthProviders + requireAuth:false expired-token path
heskew 08b9f1e
fix: fail-closed when onValidationError returns undefined
heskew 2c90dfa
docs/test: document + cover clearOAuthSession production vs fallback …
heskew edef825
doc/test: pin onValidationError contract (requireAuth coupling + stat…
heskew 1fa1e01
fix: close static-method dispatch bypass; preserve 405 for unimplemen…
heskew e408f7d
fix: preserve 405 against Harper-shaped base; harden dedup across dis…
heskew b0d770d
Merge remote-tracking branch 'origin/main' into fix/withOAuthValidati…
heskew 1cbfb46
test: pin 3-arg static dispatch shape (target, data, request)
heskew 6e584e8
style: apply prettier to 3-arg static test
heskew 93a7d10
Merge remote-tracking branch 'origin/main' into fix/withOAuthValidati…
heskew File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.