Remove unused getValues(), getValuesCount(), and all ifVersion references - #72
Merged
Conversation
cb1kenobi
marked this pull request as ready for review
July 9, 2025 23:23
cb1kenobi
changed the title
getValues(), getValuesCount(), and all ifVersion references
kriszyp
approved these changes
Jul 10, 2025
kriszyp
left a comment
kriszyp
left a comment
Member
There was a problem hiding this comment.
This is great. I will file a follow-up ticket for taking another look at estimating counts sometime, but I know that looks like it could be challenging to figure out.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
dupSort,getValues(), andgetValuesCount()will be implemented in Harper instead ofrocksdb-js.rocksdb-jsdoesn't need the "version", so we can remove theifVersionreferences.Removing
RangeIterablereferences from readme.