refactor(config): alphabetize the instance Config nav items#1470
Conversation
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
There was a problem hiding this comment.
Code Review
This pull request reorganizes the navigation links in the configuration index page to be in alphabetical order, including Certificates, Deployments, Roles, Secrets, SSH Keys, and Users. There are no review comments, and I have no additional feedback to provide.
kriszyp
left a comment
kriszyp
left a comment
There was a problem hiding this comment.
Approving. I traced every list item through the reorder and it's behavior-preserving: no route, gate, icon, or default changed. Each Link keeps its exact target and its existing condition (certsAvailable, deploymentsAvailable, secretsSupported, and the canManage wrapper), and Overview stays pinned at the top with its divider. It's purely sibling order flipping to alphabetical. Safe to land.
One non-blocking design question worth a thought (not asking you to change anything):
The previous order looks like it may have been deliberate frequency/importance-first — Users and Roles, the two most-used Config pages, sat at the top, and alphabetizing moves them to the bottom purely on spelling. At this list size (~7 items) you're below the threshold where alphabetical's scan-cost win ("binary-search with your eyes") really pays off — under roughly 8-12 items people still read the list linearly top-to-bottom, so importance-ordering arguably serves users a bit better today.
The strongest argument for alphabetical here is stability as the list grows: new items (like Secrets) drop into a predictable slot instead of forcing a subjective "where does this rank?" call each time. So this is really future-proofing toward the size where scanning dominates, at the cost of a small present-day frequency win.
If you wanted a middle path: pin the 2-3 highest-traffic entries (Users, Roles) at the top and alphabetize the tail — you get the predictable-insertion benefit without demoting the most-used pages. Purely a judgment call, and I'm genuinely fine with it either way; just flagging that the tradeoff is demoting the most-used pages.
— Claude (Sonnet 5), on behalf of Kris, via review-queue
|
The previous order was by when things were added. In a future PR we could make a data driven choice to break from alphabetical if we are seeing user confusion. We could also take that as a sign that we need to surface certain features in higher priority areas. |
Overview stays pinned at the top (and keeps its divider); the remaining items — Certificates, Deployments, Domains, Roles, Secrets, SSH Keys, Users — are now ordered alphabetically instead of by when each was added. Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
e9503b6 to
b67136e
Compare
Coverage Report
File Coverage
|
||||||||||||||||||||||||||||||||||||||
2 participants
What
Reorders the instance Config page nav so the items read alphabetically. Overview stays pinned at the top and keeps its divider (
border-t) from the rest — only the items below the divider move.Before → after:
(“Secrets” is the entry #1402 adds; it slots in alphabetically here so the two PRs don't fight over ordering.)
Only the JSX order in
src/features/instance/config/index.tsxchanged. Every item keeps its icon and its existing version/permission gate (certsAvailable,deploymentsAvailable,secretsSupported, self-managed/local checks) — nothing was added or removed, just resequenced. Icon imports were already alphabetized on the base branch, so no import change.Verification
tsc,oxlint,dprintall clean via the pre-commit hooks.🤖 Generated with Claude Code