fix(ssh-keys): validate Add SSH Key form onChange#1554
Merged
Conversation
The form had no validation mode, so RHF defaulted to onSubmit — but the submit button is gated on formState.isValid, which onSubmit mode never computes. Validation could never run and the button stayed disabled. onChange matches the other forms (ClusterForm, log config) and surfaces field errors as the user types. Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
Coverage Report
File Coverage
|
||||||||||||||||||||||||||||||||||||||
dawsontoth
approved these changes
Jul 24, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The form had no validation mode, so RHF defaulted to onSubmit — but the submit button is gated on formState.isValid, which onSubmit mode never computes. Validation could never run and the button stayed disabled. onChange matches the other forms (ClusterForm, log config) and surfaces field errors as the user types.