Stage#2
Merged
Merged
Conversation
clean up packages remove old harperdb provider
shape data to have body element split out appData from auth Data Instance Users/Add User
This was referenced Jul 9, 2026
Merged
dawsontoth
added a commit
that referenced
this pull request
Jul 13, 2026
…saved tier switch Review feedback from Kris on #1402: - Managed-cluster banner flash: while the cluster lookup was pending, `cluster === undefined` read as self-managed, so the public-key query targeted the node and failed on a CM-custody cluster, flashing the read-only banner. Gate the key fetch on the cluster query settling (or no clusterId, i.e. local Studio, where the node is correct). - Live grants editor on an unsaved tier switch: flipping a processEnv secret to Scoped (not yet saved) rendered the live SecretGrantsEditor, whose Grant fires grant_secret against a still-processEnv secret → rejected. Gate it behind an unsaved change: show a "save as scoped first" hint until the scoped save lands. Minor items: - PendingGrantsInput commits a typed-but-not-Added grant on blur, so submitting the Add form no longer silently drops it. - Clear the set_secret mutation after each call so the plaintext value doesn't linger in useMutation variables. - Comment the Secrets nav gate: manage-gated like its siblings, and the secret ops are super_user-only server-side. Covers fix #2 with two jsdom tests (grants editor hidden on the unsaved switch, shown when the stored tier is already scoped). Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.