Stage#3
Merged
Merged
Conversation
This was referenced Jul 14, 2026
kylebernhardy
added a commit
that referenced
this pull request
Jul 15, 2026
…net detection Addresses kriszyp + dawsontoth review feedback on #1511. registry-smoke.test.tsx: - Fix dead SVG selector: assert `svg` directly instead of `.recharts-responsive-container, svg` (the wrapper div is an ancestor of the svg and always matched first, so the svg branch never evaluated). The analytics setup forces 800×600 so recharts genuinely draws (kriszyp). - Make `.spec` access consistent: `specRegistry[metric].spec` non-optionally in syntheticRecords, matching MUST_RENDER_CHART (spec is required on SpecRegistryEntry) (kriszyp nit). - Add a derived-registry no-crash tier iterating Object.keys(derivedRegistry). MetricRenderer dispatches derivedRegistry[metric] before specRegistry, so the five derived metrics (mqtt-traffic-sent/received, request-rate, error-rate, transaction-log-growth) previously had zero coverage. Fed synthetic records carrying the raw source columns each recompute reads directly (kriszyp #1). - Add dedicated real-render cases for the non-cartesian primitives: heatmap (replication-latency) asserts a `[role="grid"]` with gridcells from a 2×2 source/destination matrix; small-multiples (resource-usage) asserts multiple sub-charts. Both assert real DOM, not their empty state (dawson #1521). failOnRenderPhaseUpdate.ts: - Add a tripwire-net self-check: capture the installed wrapper in beforeEach and, in afterEach, detect + defensively restore when a test replaced console.error and left it replaced (net disabled). Severity is a loud console.warn naming the test, not a hard failure, so the tests that legitimately mock console.error keep passing. Refactored into exported installTripwire / detectDisabledNet and added failOnRenderPhaseUpdate.test.ts proving the detection fires (dawson #1520). - Document the DEV-mode dependency: the net relies on React's dev-build warning and silently goes green under a production React build (dawson #3 / kriszyp #3). - Simplify the already-failed path to call console.error directly (restored two lines up) instead of original?.() (kriszyp nit). queryClient.test.ts: - The new self-check surfaced that this suite used mockReset() (leaves a swallowing spy installed at teardown); switch to mockRestore() so the tripwire wrapper is back in place between tests. Fixes #1520 Fixes #1521 Co-Authored-By: Claude Fable 5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01UZEaYdKFXuQw2Hf6XpPdEV
dawsontoth
pushed a commit
that referenced
this pull request
Jul 22, 2026
…net detection Addresses kriszyp + dawsontoth review feedback on #1511. registry-smoke.test.tsx: - Fix dead SVG selector: assert `svg` directly instead of `.recharts-responsive-container, svg` (the wrapper div is an ancestor of the svg and always matched first, so the svg branch never evaluated). The analytics setup forces 800×600 so recharts genuinely draws (kriszyp). - Make `.spec` access consistent: `specRegistry[metric].spec` non-optionally in syntheticRecords, matching MUST_RENDER_CHART (spec is required on SpecRegistryEntry) (kriszyp nit). - Add a derived-registry no-crash tier iterating Object.keys(derivedRegistry). MetricRenderer dispatches derivedRegistry[metric] before specRegistry, so the five derived metrics (mqtt-traffic-sent/received, request-rate, error-rate, transaction-log-growth) previously had zero coverage. Fed synthetic records carrying the raw source columns each recompute reads directly (kriszyp #1). - Add dedicated real-render cases for the non-cartesian primitives: heatmap (replication-latency) asserts a `[role="grid"]` with gridcells from a 2×2 source/destination matrix; small-multiples (resource-usage) asserts multiple sub-charts. Both assert real DOM, not their empty state (dawson #1521). failOnRenderPhaseUpdate.ts: - Add a tripwire-net self-check: capture the installed wrapper in beforeEach and, in afterEach, detect + defensively restore when a test replaced console.error and left it replaced (net disabled). Severity is a loud console.warn naming the test, not a hard failure, so the tests that legitimately mock console.error keep passing. Refactored into exported installTripwire / detectDisabledNet and added failOnRenderPhaseUpdate.test.ts proving the detection fires (dawson #1520). - Document the DEV-mode dependency: the net relies on React's dev-build warning and silently goes green under a production React build (dawson #3 / kriszyp #3). - Simplify the already-failed path to call console.error directly (restored two lines up) instead of original?.() (kriszyp nit). queryClient.test.ts: - The new self-check surfaced that this suite used mockReset() (leaves a swallowing spy installed at teardown); switch to mockRestore() so the tripwire wrapper is back in place between tests. Fixes #1520 Fixes #1521 Co-Authored-By: Claude Fable 5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01UZEaYdKFXuQw2Hf6XpPdEV
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.