Skip to content

STUDIO-65 - #360

Merged
deliciousmonster merged 24 commits into
stagefrom
STUDIO-65-LOCAL
Nov 22, 2023
Merged

STUDIO-65#360
deliciousmonster merged 24 commits into
stagefrom
STUDIO-65-LOCAL

Conversation

@deliciousmonster

Copy link
Copy Markdown
Contributor

This adds two new commands to package.json:

yarn start:local

  • This injects an ENV var into config.js called is_local_studio
  • This variable is used to replace App.js with LocalApp.js
  • There is also a LocalSignIn.js component that logs directly into the instance
  • That config var is used throughout the app to tweak the UI for a local-only experience

yarn build:local

  • This injects an ENV var into config.js called is_local_studio
  • This places the local-studio-specific files into a build-local folder
  • This includes running.html, which is used when localStudio is not enabled
  • The artifacts of this build can be copied into core, at harperdb/studio

NOTES:

  • I removed the external dependencies on fontawesome, and brought them local
  • I lazy-load the App and LocalApp files to keep the local version from trying to load Stripe.js when offline

@todo:

  • Not sure about clustering configuration, since it uses the other instances from getInstances to populate it. You may have to comment replication out for the local studio
  • For narrow clients, the dropdown navigation isn't working

to build, use build:local.
it will put it into a build-local directory, which you can copy into harperdb/studio
@deliciousmonster deliciousmonster changed the title Local Studio STUDIO-65 Nov 16, 2023
@deliciousmonster
deliciousmonster marked this pull request as draft November 16, 2023 05:09
@deliciousmonster
deliciousmonster marked this pull request as ready for review November 16, 2023 05:10
@foundling
foundling force-pushed the STUDIO-65-LOCAL branch 2 times, most recently from 1369c1c to f8ff1c7 Compare November 16, 2023 20:14

@foundling foundling left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great, thanks for handling this!

@sonarqubecloud

Copy link
Copy Markdown

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 157 Code Smells

No Coverage information No Coverage information
0.6% 0.6% Duplication

@deliciousmonster
deliciousmonster merged commit 581e6b8 into stage Nov 22, 2023
@deliciousmonster
deliciousmonster deleted the STUDIO-65-LOCAL branch November 22, 2023 19:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants