Skip to content

[FIX] [BUG] Omit/Include credentials options on fetch based upon auth header" #405

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
BboyAkers merged 6 commits into from
Nov 1, 2024
Merged

[FIX] [BUG] Omit/Include credentials options on fetch based upon auth header" #405

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
6 commits
Select commit Hold shift + click to select a range
0c1a7cd
Merge pull request #400 from HarperDB/stage
kriszyp Oct 7, 2024
95ba8b1
Merge pull request #402 from HarperDB/stage
deliciousmonster Oct 9, 2024
e148963
Reduce new instance name max character count from 15 to 14 characters.
BboyAkers Oct 30, 2024
cbdaba3
Merge pull request #404 from HarperDB/aakers/Studio-99
BboyAkers Oct 31, 2024
2ecd13b
omit/include credentials options on fetch based upon headers
BboyAkers Nov 1, 2024
ab8a05c
Merge branch 'stage' into aakers/login-bug
BboyAkers Nov 1, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 3 additions & 2 deletions package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
{
"name": "harperdb-studio",
"version": "4.6.0",
"version": "4.6.1",
"description": "A UI for HarperDB",
"deploymentUrl": "studio.harperdb.io",
"private": true,
Expand Down Expand Up @@ -84,5 +84,6 @@
"stylelint-order": "^6.0.1",
"stylelint-scss": "^6.0.0",
"typescript": "^5.6.2"
}
},
"packageManager": "yarn@1.22.22+sha512.a6b2f7906b721bba3d67d4aff083df04dad64c399707841b7acf00f6b133b7ac24255f2652fa22ae3534329dc6180534e98d17432037ff6fd140556e2bb3137e"
}
5 changes: 3 additions & 2 deletions src/components/instances/new/MetaLocal.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -98,7 +98,7 @@ function MetaLocal() {
<>
<Card>
<CardBody>
<ContentContainer header="Instance Name" subheader="letters, numbers, and hyphens only. 16 char max.">
<ContentContainer header="Instance Name" subheader="letters, numbers, and hyphens only. 14 char max.">
<Row>
<Col sm="4" className="pt-2 text-nowrap text-grey">
Example: &quot;local-1&quot;
Expand All @@ -113,10 +113,11 @@ function MetaLocal() {
.replace(/^0+/, '')
.replace(/^-+/, '')
.replace(/[^a-z\d-]+/gi, '')
.substring(0, 15)
.substring(0, 14)
.toLowerCase(),
})
}
max={14}
type="text"
title="instance_name"
value={formData.instance_name}
Expand Down
2 changes: 1 addition & 1 deletion src/functions/api/queryInstance.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -17,7 +17,7 @@ export default async ({ operation, auth, url, timeout = 0, authType = undefined,
method: 'POST',
body: JSON.stringify(operation),
headers,
credentials: 'include',
credentials: headers.Authorization ? 'omit' : 'include',
});

clearTimeout(id);
Expand Down