Skip to content

[Enhancement] UI Update: Auth Pages have a new UI#408

Merged
kriszyp merged 25 commits into
stagefrom
akers/STUDIO-52
Nov 12, 2024
Merged

[Enhancement] UI Update: Auth Pages have a new UI#408
kriszyp merged 25 commits into
stagefrom
akers/STUDIO-52

Conversation

@BboyAkers

@BboyAkers BboyAkers commented Nov 8, 2024

Copy link
Copy Markdown
Member

Ticket:

STUDIO-52

Overview:

  • UI update for auth pages:
    • Sign In
    • Local Sign In
    • Sign Up
    • Reset Password
  • All 3 themes are updated as well for these pages.
  • Version bump 4.6.3 -> 4.7.0

Manual Testing:

  1. Navigate to Sign In page /
  2. Navigate to Sign Up page /sign-up
  3. Navigate to Reset password Page /reset-password
  4. Navigate to Local Sign In page via yarn run start:local

Expected Result:
Mobile and Desktop view should look seamless.

Additional Context:

Did a Design QA walkthrough with Kandice, she approved it! On Monday she will give me the update in regards to the ideal "purple" theme for mobile view.

BboyAkers and others added 2 commits November 1, 2024 16:01
@BboyAkers
BboyAkers changed the base branch from master to stage November 8, 2024 19:33
@BboyAkers
BboyAkers marked this pull request as ready for review November 8, 2024 20:08
@BboyAkers

BboyAkers commented Nov 8, 2024

Copy link
Copy Markdown
Member Author

SonarCloud Code Analysis marked the error text and email input field for SignIn and ResetPassword as duplicate code. I don't believe abstracting that duplicate code into another component is necessary. Is it possible for someone to look at SonarCloud Code Analysis and approve it if my rationale is correct?

@kriszyp kriszyp left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great, nice job!

Comment thread src/components/layouts/App.js Outdated
Comment thread src/components/TopNav.js Outdated
Comment thread src/components/auth/ResetPassword.js Outdated
Comment thread src/components/auth/SignUp.js Outdated

@Ethan-Arrowood Ethan-Arrowood left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm :)

@sonarqubecloud

Copy link
Copy Markdown

Quality Gate Failed Quality Gate failed

Failed conditions
3.6% Duplication on New Code (required ≤ 3%)

See analysis details on SonarCloud

@kriszyp
kriszyp merged commit 3173c7d into stage Nov 12, 2024
@kriszyp

kriszyp commented Nov 12, 2024

Copy link
Copy Markdown
Member

Looking at the staging page, one thing I will mention is that it seems like the "buttons" for Docker and NPM should actually link to our Docker and NPM URLs.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants