Caching Describe Table Call, Reducing Expensive Call To Backend#426
Merged
Conversation
BboyAkers
marked this pull request as draft
November 22, 2024 01:06
BboyAkers
changed the title
BboyAkers
force-pushed
the
aakers/cache-table-data
branch
from
December 4, 2024 20:13
e03e1a1 to
ce41e72
Compare
BboyAkers
changed the title
BboyAkers
marked this pull request as ready for review
December 6, 2024 06:07
Ethan-Arrowood
approved these changes
Dec 6, 2024
Ethan-Arrowood
left a comment
Ethan-Arrowood
left a comment
Member
There was a problem hiding this comment.
lgtm with some minor improvements
kriszyp
reviewed
Dec 6, 2024
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Ticket
STUDIO-122
Overview
describe_tablecall to reduce the frequency of that expensive call being made to the backendManual Testing
Testing:
Expected Result:
The describe_table api call should not be triggered when navigating through pages of table data results.
Additional Notes:
The describe_table cache is reset every 60 seconds.