Skip to content

Temporarily disabling /charts route #431

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
BboyAkers merged 2 commits into from
Nov 25, 2024
Merged

Temporarily disabling /charts route #431

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
383d744
Merge pull request #430 from HarperDB/stage
BboyAkers Nov 25, 2024
62817b5
Temporarily disabling /charts route
BboyAkers Nov 25, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
{
"name": "harperdb-studio",
"version": "4.8.4",
"version": "4.8.5",
"description": "A UI for HarperDB",
"deploymentUrl": "studio.harperdb.io",
"private": true,
Expand Down
23 changes: 12 additions & 11 deletions src/components/instance/routes.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3,8 +3,8 @@ import { lazy, React } from 'react';
import Browse from './browse';
import config from '../../config';
import supportsApplications from '../../functions/instance/functions/supportsApplications';

const Charts = lazy(() => import(/* webpackChunkName: "instance-charts" */ './charts'));
// NOTE: Temporarily disabling. Query is used in Charts.
// const Charts = lazy(() => import(/* webpackChunkName: "instance-charts" */ './charts'));
// NOTE: Temporarily disabling. The SQL engine in HarperDB is not optimized and when users use it, it can create significant production issues.
// const Query = lazy(() => import(/* webpackChunkName: "instance-query" */ './query'));
const Cluster = lazy(() => import(/* webpackChunkName: "instance-cluster" */ './replication'));
Expand Down Expand Up @@ -50,13 +50,14 @@ const routes = ({ super_user, version = null }) => {
icon: 'check-square',
};

const charts = {
element: <Charts />,
path: `charts`,
link: 'charts',
label: 'charts',
icon: 'chart-line',
};
// NOTE: Temporarily disabling. Query is used in Charts.
// const charts = {
// element: <Charts />,
// path: `charts`,
// link: 'charts',
// label: 'charts',
// icon: 'chart-line',
// };

const cluster = {
element: <Cluster />,
Expand Down Expand Up @@ -103,11 +104,11 @@ const routes = ({ super_user, version = null }) => {
}

if (super_user) {
return [browse, users, roles, charts, cluster, useApplications ? applications : functions, metrics, configure];
return [browse, users, roles, cluster, useApplications ? applications : functions, metrics, configure];
}

if (config.is_local_studio) {
return [browse, charts];
return [browse];
}

return [browse];
Expand Down