Simplify routing layout(s)#450
Merged
Merged
Conversation
|
BboyAkers
commented
Dec 17, 2024
| > | ||
| {/* can we put instance routes in here, each in a suspense tag (since they're lazily loaded) */} | ||
| ) : ( | ||
| <main id={loggedIn ? 'app-container' : ''} className={!loggedIn ? 'auth-container' : ''}> |
Member
Author
There was a problem hiding this comment.
Not the most ideal and it works! My objective was to simplify the layout/routing and reduce the amount of used buttttt if ya'll have any better suggestions please let me know! 🙂
deliciousmonster
approved these changes
Dec 17, 2024
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Ticket
None
Overview
layouts/App.jsApp.jsfileManual Testing
Expected Result:
Nothing should've changed in terms of functionality and views.