Conversation
kriszyp
left a comment
There was a problem hiding this comment.
Great job, this is a huge improvement over the previous log viewer.
I will share some of my own (mostly subjective) preferences for log viewing. First, (maybe a little more objective), reading the body of a log message in log info dialog in dark mode is pretty hard:

Generally, the act of log viewing generally involves looking through a large amount of log information and quickly scanning for key bits of information. Consequently, good/mature log viewing tools generally feature high information density, balanced with text legibility. However, in the studio log viewer, much of the screen real estate is "wasted":

The first five columns take up most of the horizontal space even though they are small bits of text. The log message is by far the most important part of the log entry, but it receives a minority of the space. The columns should be adjusted so that the Message column uses about 60%-70% of the horizontal space.
Vertically, the space usage is sub-optimal as well, with the actual content often compromising a small amount of the available space, with font size that is probably a little small, and too much line spacing. I would think you typically want the text height to at least be 50% of the line height. Here is an example of typical log viewing from a terminal that I would consider highly efficient:

Also, why does the scrollbar have to be so tiny for dragging (scrolling is often the first thing I do when I am looking at logs)?

Anyway, some of this is probably beyond the scope of what you were aiming to tackle with this PR, and some might be somewhat preferential. You should probably fix the Log Info dialog in dark mode for this PR, but beyond that, I am fine with merging this PR and doing further log updates at a different time, if you prefer.
Again, this is a great step forward, nice work!
|
Fixed:
|
|
Update:
|
|




Ticket
STUDIO-160
Overview
/Logssub-route for instances to view server logs