Skip to content

Update README.md#48

Merged
Havret merged 2 commits into
Havret:mainfrom
robertlyson:patch-1
Jun 14, 2022
Merged

Update README.md#48
Havret merged 2 commits into
Havret:mainfrom
robertlyson:patch-1

Conversation

@robertlyson

Copy link
Copy Markdown
Contributor

Thought it will be good idea to include JsonLowerCaseNamingPolicy in example, started to look for it in google and then realized it's a custom policy. Maybe also good to include this naming policy in source code so folks don't need to create it? Let me know, happy to do it.

Thought it will be good idea to include `JsonLowerCaseNamingPolicy` in example, started to look for it in google and then realized it's a custom policy. Maybe also good to include this naming policy in source code so folks don't need to create it? Let me know, happy to do it.
@Havret

Havret commented Jun 14, 2022

Copy link
Copy Markdown
Owner

Hi @robertlyson. Maybe to not confuse people too much, it would be better to use policy that's already available in System.Text.Json, like JsonCamelCaseNamingPolicy. At least in README.md.

When I was writing this docs I just copied the code from one of the tests.

@robertlyson

Copy link
Copy Markdown
Contributor Author

@Havret sounds good 👍 fixed.

@Havret Havret left a comment

Copy link
Copy Markdown
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looking good. Thanks!

@Havret
Havret merged commit d511a44 into Havret:main Jun 14, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants