Skip to content

[cppia] Do not generate __scriptableFunctions from parent classes#5502

Merged
hughsando merged 2 commits intoHaxeFoundation:developmentfrom
waneck:vtable-fix
Aug 8, 2016
Merged

[cppia] Do not generate __scriptableFunctions from parent classes#5502
hughsando merged 2 commits intoHaxeFoundation:developmentfrom
waneck:vtable-fix

Conversation

@waneck
Copy link
Copy Markdown
Member

@waneck waneck commented Aug 7, 2016

Currently, the __scriptableFunctions array is being filled with functions
from all base classes. This not only makes the vtable grow very big,
but also confuses the vtable numbering in such a way that it is possible
to override a wrong function.

The changed test failed in multiple different ways because of that.

@waneck waneck added the platform-cpp Everything related to CPP / C++ label Aug 7, 2016
Currently, the __scriptableFunctions array is being filled with functions
from all base classes. This not only makes the vtable grow very big,
but also confuses the vtable numbering in such a way that it is possible
to override a wrong function
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

platform-cpp Everything related to CPP / C++

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants