Use dedicated base R functions to simplify some code patterns - #159
Merged
Conversation
Bisaloo
commented
Apr 24, 2026
Comment on lines
+92
to
+93
| scales <- vapply(object@data, \(x) paste0(dim(x), collapse=","), character(1)) | ||
| coolcat("Scales (%d): (%s)", scales) |
Collaborator
Author
There was a problem hiding this comment.
I'm less sure about this one. It is probably worth running some extra tests for this.
HelenaLC
added a commit
that referenced
this pull request
Jul 5, 2026
Use dedicated base R functions to simplify some code patterns Former-commit-id: 3c4d422 Former-commit-id: 72f971c507daf37a960fdfb97a793d1372c7c1d4
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This should also result in tiny performance improvements. However, if the modified functions are called in tight loops, the performance improvement may be noticeable.