Skip to content

merge for v1.2.0#121

Merged
antmsbrito merged 86 commits into
mainfrom
updates
May 21, 2025
Merged

merge for v1.2.0#121
antmsbrito merged 86 commits into
mainfrom
updates

Conversation

@brunomsaraiva
Copy link
Copy Markdown
Collaborator

No description provided.

@codecov-commenter
Copy link
Copy Markdown

codecov-commenter commented May 20, 2025

Codecov Report

❌ Patch coverage is 86.11111% with 5 lines in your changes missing coverage. Please review.
✅ Project coverage is 82.44%. Comparing base (c2637fc) to head (f81bc57).
⚠️ Report is 251 commits behind head on main.

Files with missing lines Patch % Lines
src/nanopyx/core/utils/easy_gui.py 87.50% 2 Missing ⚠️
src/nanopyx/methods/esrrf/eSRRF_workflow.py 75.00% 1 Missing ⚠️
src/nanopyx/methods/esrrf_3d/eSRRF3D_workflow.py 88.88% 1 Missing ⚠️
src/nanopyx/methods/srrf/SRRF_workflow.py 75.00% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #121      +/-   ##
==========================================
+ Coverage   78.09%   82.44%   +4.34%     
==========================================
  Files          37       54      +17     
  Lines        1324     1333       +9     
==========================================
+ Hits         1034     1099      +65     
+ Misses        290      234      -56     
Flag Coverage Δ
pytests 82.44% <86.11%> (+4.34%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@antmsbrito antmsbrito self-requested a review May 21, 2025 07:48
Comment thread src/include/_c_sr_radial_gradient_convergence.c
Comment thread src/nanopyx/core/transform/_interpolation.pyx
Comment thread src/nanopyx/methods/esrrf_3d/eSRRF3D_workflow.py
Copy link
Copy Markdown
Collaborator

@antmsbrito antmsbrito left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Left a couple comments of things that would be nice to clean up like docstrings and unused imports but everything looks good.

@antmsbrito antmsbrito merged commit 1ef79d4 into main May 21, 2025
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants