Skip to content

fix(android): require explicit release signing #14

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
Hidden-Node merged 1 commit into from
May 14, 2026
+14 −1
Merged

fix(android): require explicit release signing #14

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
15 changes: 14 additions & 1 deletion android/app/build.gradle.kts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -57,7 +57,9 @@ android {
isMinifyEnabled = true
isShrinkResources = true
val signingEnabled = System.getenv("ANDROID_SIGNING_ENABLED") == "true"
signingConfig = if (signingEnabled) signingConfigs.getByName("release") else signingConfigs.getByName("debug")
if (signingEnabled) {
signingConfig = signingConfigs.getByName("release")
}
proguardFiles(
getDefaultProguardFile("proguard-android-optimize.txt"),
"proguard-rules.pro"
Expand Down Expand Up @@ -95,6 +97,17 @@ android {
}
}

gradle.taskGraph.whenReady {
val releaseTaskRequested = allTasks.any { task ->
task.path.startsWith(":app:") && task.name.contains("Release")
}
if (releaseTaskRequested && System.getenv("ANDROID_SIGNING_ENABLED") != "true") {
throw org.gradle.api.GradleException(
"Release builds require ANDROID_SIGNING_ENABLED=true and Android signing environment variables."
)
}
}

dependencies {
// Go mobile library (built via gomobile bind)
implementation(fileTree(mapOf("dir" to "libs", "include" to listOf("*.aar", "*.jar"))))
Expand Down
Loading