workflows: check autogenerated files when commands change - #23258
Merged
MikeMcQuaid merged 2 commits intoAug 6, 2026
Conversation
8 tasks
Contributor
|
This is already covered by https://github.com/Homebrew/brew/blob/main/.github/workflows/sponsors-maintainers-man-completions.yml. |
Member
|
@p-linnane That'll do it automatically but I think it's worth considering having at least a 馃敶 warning to encourage users to do it for us. |
Contributor
Author
|
I feel neutral about either path. I made this based on feedback I received on a different PR: #23152 (review) |
kmarekspartz
marked this pull request as ready for review
August 5, 2026 22:39
Contributor
Author
|
Moving this out of draft as my other PR was merged. |
MikeMcQuaid
approved these changes
Aug 6, 2026
MikeMcQuaid
left a comment
Member
There was a problem hiding this comment.
Thanks. Let's try this and see if it gets annoying.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
brewcommands to reproduce the bug?brew lgtm(style, typechecking and tests) locally?