Skip to content

workflows: check autogenerated files when commands change - #23258

Merged
MikeMcQuaid merged 2 commits into
Homebrew:mainfrom
kmarekspartz:autogenerated-files-trigger
Aug 6, 2026
Merged

workflows: check autogenerated files when commands change#23258
MikeMcQuaid merged 2 commits into
Homebrew:mainfrom
kmarekspartz:autogenerated-files-trigger

Conversation

@kmarekspartz

Copy link
Copy Markdown
Contributor

  • Have you followed our Contributing guidelines?
  • Have you checked for other open Pull Requests for the same change?
  • Have you explained what your changes do? Performance claims (e.g. "this is faster") must include Hyperfine benchmarks.
  • Have you explained why you'd like these changes included, not just what they do?
  • For bug fixes, have you given step-by-step brew commands to reproduce the bug?
  • [NA] Have you written new tests (excluding integration tests)? Here's an example.
  • [NA] Have you successfully run brew lgtm (style, typechecking and tests) locally?

  • AI was used to generate or assist with generating this PR.

@p-linnane

Copy link
Copy Markdown
Contributor

@p-linnane p-linnane closed this Jul 23, 2026
@MikeMcQuaid MikeMcQuaid reopened this Jul 23, 2026
@MikeMcQuaid

Copy link
Copy Markdown
Member

@p-linnane That'll do it automatically but I think it's worth considering having at least a 馃敶 warning to encourage users to do it for us.

@kmarekspartz

Copy link
Copy Markdown
Contributor Author

I feel neutral about either path. I made this based on feedback I received on a different PR: #23152 (review)

@kmarekspartz
kmarekspartz marked this pull request as ready for review August 5, 2026 22:39
@kmarekspartz

Copy link
Copy Markdown
Contributor Author

Moving this out of draft as my other PR was merged.

@MikeMcQuaid MikeMcQuaid left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks. Let's try this and see if it gets annoying.

@MikeMcQuaid
MikeMcQuaid added this pull request to the merge queue Aug 6, 2026
Merged via the queue into Homebrew:main with commit ad31b20 Aug 6, 2026
43 checks passed
@kmarekspartz
kmarekspartz deleted the autogenerated-files-trigger branch August 6, 2026 15:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants