Skip to content

Fix AppImage's stanza name in cask DSL - #23447

Merged
MikeMcQuaid merged 2 commits into
Homebrew:mainfrom
AlternateRT:fix-appimage-cask-dsl
Aug 5, 2026
Merged

Fix AppImage's stanza name in cask DSL#23447
MikeMcQuaid merged 2 commits into
Homebrew:mainfrom
AlternateRT:fix-appimage-cask-dsl

Conversation

@AlternateRT

@AlternateRT AlternateRT commented Aug 5, 2026

Copy link
Copy Markdown
Contributor

  • Have you followed our Contributing guidelines?
  • Have you checked for other open Pull Requests for the same change?
  • Have you explained what your changes do? Performance claims (e.g. "this is faster") must include Hyperfine benchmarks.
  • Have you explained why you'd like these changes included, not just what they do?
  • For bug fixes, have you given step-by-step brew commands to reproduce the bug?
  • Have you written new tests (excluding integration tests)? Here's an example.
  • Have you successfully run brew lgtm (style, typechecking and tests) locally?

  • I did not use AI/LLM to create this PR, or I disclosed the tool/model below and reviewed its output; I did not attribute commits to AI and will answer maintainer questions and review comments myself without AI/LLM.

The correct name for this stanza - the one that is actually being used - is app_image. This fixes the cask DSL so that it is properly covered by stanza ordering rules.

Also documents all the newer artifact classes that were not documented.

@AlternateRT
AlternateRT force-pushed the fix-appimage-cask-dsl branch from 70658db to a34997f Compare August 5, 2026 11:57

@MikeMcQuaid MikeMcQuaid left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@MikeMcQuaid
MikeMcQuaid added this pull request to the merge queue Aug 5, 2026
Merged via the queue into Homebrew:main with commit 4798afc Aug 5, 2026
42 checks passed
@AlternateRT
AlternateRT deleted the fix-appimage-cask-dsl branch August 5, 2026 16:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants