Skip to content

fixed onDrain call when queue is drained #6

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
dmytro-doroshenko wants to merge 1 commit into
base: master
Choose a base branch
from
Open

fixed onDrain call when queue is drained #6

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
fixed onDrain call when queue is drained
  • Loading branch information
@dmytro-doroshenko
dmytro-doroshenko committed Apr 2, 2024
commit aa09cfe26490ee567e70557ddd963c6a5b540739
2 changes: 1 addition & 1 deletion JavaScript/6-promise.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -34,7 +34,6 @@ class Queue {
(err) => void this.finish(err)
)
.finally(() => {
this.count--;
if (this.waiting.length > 0) this.next();
});
}
Expand All @@ -45,6 +44,7 @@ class Queue {
if (err && onFailure) onFailure(err, res);
else if (onSuccess) onSuccess(res);
if (onDone) onDone(err, res);
this.count--;
if (this.count === 0 && this.waiting.length === 0 && onDrain) onDrain();
}

Expand Down