Remove awscli dependency#572
Conversation
Codecov Report
@@ Coverage Diff @@
## master #572 +/- ##
==========================================
- Coverage 97.43% 97.42% -0.02%
==========================================
Files 88 88
Lines 8375 8378 +3
==========================================
+ Hits 8160 8162 +2
- Misses 215 216 +1
📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
|
TODO get rid of scripts that download from aws |
|
Having a touch of trouble testing due to #576. |
|
Current status:
I turned the last bullet point into its own issue (#576), but think it should be addressed separately - IMO it kind of sucks that someone can't just clone this repository and run |
|
BTW I kept |
AdamGleave
left a comment
There was a problem hiding this comment.
LGTM apart from deleting one section that I think shouldn't have been.
|
|
||
| To analyze these results, run `python -m imitation.scripts.analyze with run_name=RUN_NAME`. Analysis can be run even while training is midway (will only show completed imitation learner's results). [Example output.](https://gist.github.com/shwang/4049cd4fb5cab72f2eeb7f3d15a7ab47) | ||
|
|
||
| ### Phase 4: Transfer learning. |
There was a problem hiding this comment.
Why did you delete this? If it was because experiments/transfer_benchmark.sh doesn't exist I think it just got renamed to experiments/transfer_learn_benchmark.sh.
There was a problem hiding this comment.
I think maybe I deleted it because currently stuff doesn't save to data/reward_models. I guess I can reinstate it and leave fixing it for a general "make the experiment scripts work" PR.
There was a problem hiding this comment.
Have reinstated it.
There was a problem hiding this comment.
Ah yeah that is a problem but agree probably best to punt it to another issue. We should really overhaul the whole experiments/ directory -- I expect @taufeeque9 will end up doing this as part of his benchmarking work.
Description
Fixes #560.
Testing
Ran all tests. Results: 3543 passed, 595 skipped, 4234 warnings.