Skip to content

Improve project Id input#35

Merged
pufferfish101007 merged 5 commits into
HyperQuark:mainfrom
raphaelts3:improve-project-id-input
Oct 21, 2025
Merged

Improve project Id input#35
pufferfish101007 merged 5 commits into
HyperQuark:mainfrom
raphaelts3:improve-project-id-input

Conversation

@raphaelts3
Copy link
Copy Markdown
Contributor

This PR aims to implement the changes suggested on #26 doing the following changes:

  • remove placeholder from the input;
  • keep the Go! disabled, until a valid project Id is typed;
    • valid here means:
      • only digits;
      • gets 200 response when tested against https://trampoline.turbowarp.org/api/projects/${projectId}/; The usage of HEAD method is a slight optimization to get the minimal response, since this request might get re-done later if the user hits the Go! button;

If approved, this PR closes #26.

@pufferfish101007
Copy link
Copy Markdown
Member

Hi, thank you for this.

I would rather not check for project existance via turbowarp trampoline before pressing go, as I'd prefer to hit any external services as little as possible.

Other than that, looks good.

@raphaelts3
Copy link
Copy Markdown
Contributor Author

Thank for the quick review @pufferfish101007, so your suggestion is to just remove the external check and that's it? Or use a different extra check before enabling the Go!? I will also check the lint issues.

@pufferfish101007
Copy link
Copy Markdown
Member

Yes, I'd rather just remove the external check.

The lint is not caused by your changes, so don't worry about it :)

@pufferfish101007 pufferfish101007 merged commit c17a2c8 into HyperQuark:main Oct 21, 2025
3 of 4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Project ID input on homepage is confusing

2 participants